cubicweb #1809414 add uicfg.set_field_order helper method [resolved]

This method is reimplemented again and again in various cubes:

def set_field_order(etype, attrs):
   for index, attr in enumerate(attrs):
       uicfg.autoform_field_kwargs.tag_subject_of(
           (etype, attr, '*'), {'order': index})
       uicfg.primaryview_display_ctrl.tag_subject_of(
           (etype, attr, '*'), {'order': index})

IMO, it belongs to cubicweb.

prioritynormal
typebug
done in3.14.0
load0.100
load left0.000
closed by#552d85fcb587 [uicfg] add uihelper module with high-level helpers (closes #1809414)

Workflow history

from state (4)to statecommentdateUser
validation pendingresolved2011/12/23 13:57 UTCsthenault
donevalidation pending2011/11/09 18:15 UTCsthenault
in-progressdone2011/10/27 17:03 UTC 
openin-progress2011/10/26 17:42 UTC 

Comments

  • 2011/07/06 10:14

    maybe:

    def set_field_order(etype, attrs):
   for index, attr in enumerate(attrs):
       if attr.startswith('reverse_'):
           attr = attr[8:]
           uicfg.autoform_field_kwargs.tag_object_of(
               ('*', attr, etype), {'order': index})
           uicfg.primaryview_display_ctrl.tag_object_of(
               ('*', attr, etype), {'order': index})
       else:
           uicfg.autoform_field_kwargs.tag_subject_of(
               (etype, attr, '*'), {'order': index})
           uicfg.primaryview_display_ctrl.tag_subject_of(
               (etype, attr, '*'), {'order': index})
  • 2011/11/10 13:17, written by acampeas

    This is a prefect example of code review not working.

    • 2011/11/14 11:15, written by acampeas

      Ok so I'm told the discussion happened one year ago (!) on the ML, hence the fast forward qfinish that was exercised.

      (Still the ticket only talks about a small part of the patch and contains no reference to the discussion)

add comment