cubicweb-container #3595279 compulsory_hooks_categories does not work [done]

As far as I can see, setting this attribute in the clone adapter does not enable specified hooks categories. E.g. I'm trying to set compulsory_hooks_categories=('workflow', ) but none of the workflow hooks are actually triggered during cloning.

Using the "fastimport" cube will provide an appropriate & efficient "hooksrunner" object that will honor hooks.

priorityimportant
typebug
done in2.7.0
load0.100
load left0.000
closed by<not specified>
patchClone: with non-inlined relations, use .insert_relations [applied]Clone: use the fastimport flush controller and .insert_entities [applied]

Workflow history

from state (2)to statecommentdateUser
in-progressdone2015/01/15 11:24 UTCacampeas
openin-progress2014/07/29 16:11 UTC 

Comments

  • 2014/02/27 15:46, written by acampeas

    What version of container are you working with ?

    • 2014/02/27 16:04, written by dlaxalde

      Tried with early 2.3 (50e501565b67) and later on after the series of changesets on cloning.

      • 2014/02/27 16:14, written by acampeas

        The handling of entities is now out of reach of the hooks manager from 2.3.0. We will indeed have to devise something for people that want to run hooks anyway.

  • 2014/02/27 15:47, written by acampeas

    Also note that doing compulsory_hooks_categories=('workflow', ) is not a meaningful thing to do.

    • 2014/02/27 16:07, written by dlaxalde

      Maybe I'm using the wrong tool. I want my cloned entities to be in their initial state (as defined by their workflow). So I skipped in_state relation for cloning, but the latter remains at None.

      • 2014/02/27 16:12, written by acampeas

        By _definition_ of cloning, your cloned entities will be in whatever state they where cloned from.

        • 2014/02/28 08:16, written by dlaxalde

          It seems the proper category is 'metadata' (looking at cubicweb/hooks/workflows.py). Still, it does not work.

          • 2014/02/28 09:24, written by acampeas

            What do you expect to actually happen with this hook category ?

            • 2014/02/28 09:28, written by dlaxalde

              I would expect cloned entities to be in their initial workflow state, if I skip the in_state relation for cloning. Currently, they are in an undefined state.

              • 2014/02/28 09:36, written by acampeas

                What are you trying to achieve ?

                Clone is a simple, well defined, unambiguous protocol.

                You seem to actually want a kind of _transform_. The clone machinery in itself gives some rope for this.

                If you need to reset entities states, you need to do it as an explicit step after the clone operation. The container hooks already provide some hints as how to proceed (e.g. "finalize_cloned_container").

add comment