cubicweb-collaboration #3850959 Modification of a frozen entity [validation pending]
The "modify" action is present on a frozen entity and it opens the entitie's modification form. | |
priority | important |
---|---|
type | bug |
done in | 1.0.0 |
load left | 0.000 |
closed by | <not specified> |
Comments
-
2014/05/22 08:12, written by dlaxalde
-
2014/05/22 08:19, written by vpopescu
-
2014/05/22 08:24, written by dlaxalde
-
2014/05/22 08:26, written by dlaxalde
-
2014/05/22 08:47, written by vpopescu
- one should be able to unfreeze a frozen entity as long as the entity has no clones;
- one should be able to add collaborators at any time (irrespective of the frozen / unfrozen status of the entity);
- one should be able to remove a collaborator from an entity only if the said collaborator has not cloned the entity yet (irrespective of the frozen / unfrozen status of the entity as well).
-
2014/05/22 08:46, written by ksaurfelt
-
2014/05/22 08:49, written by vpopescu
-
2014/05/22 09:06, written by dlaxalde
add commentWhich version are you using? If in 0.2.0, that's probably because you can modify the "frozen" attribute, which is arguably a design flaw.
I would say that being able to modify the frozen attribute as long as the collaborative entity is not cloned by anyone is rather a feature than a flaw: indeed, the user should be able to unfreeze an entity as long as the said entity has no clones.
Nonetheless, the "modify" action should indeed not be present as such on a frozen entity. But this should be fixed via a selector on the said action IMHO.
Being able to unfreeze is a feature, but the design was a bit strange IMO.
Anyways, this has been fixed by using workflows.
The only thing that should be able updatable is the collaborators list (collaborates_on relation).
Yes, actually, I think that:
I am using 0.2.0. My point is that we should not present the whole form if we only can modify one attribute (but this is probaly a generic cubicweb concern rather then this particular cube).
I think the "modify' action should not be available on a frozen collaborative entity. Perhaps this could be fixed via an appropriate selector on the "modify" action, couldn't it?
Hiding the collaborates_on relation from autoform and relying on inlinedit should do it (though inlinedit may not be available).