cubicweb #4801120 Wrong log levels for sql errors [resolved]

NativeSQLSource.doexec, if it catches a sql error, produces 'critical' log entries.

These log entries should not be critical:

  • If an error occur at the sql level, it will be transmitted or translated to a CW error, which is fine. But if the exception is raised and handled in a higher level function, why do we make it a critical error?
  • Admitting that rolling-back automatically on errors is wanted in some cases, how can it be considered 'critical'? The caller will receive the original exception anyway, it is its job to decide if it is critical or not.


done in3.20.4
load left0.000
closed by#4b33246cb43c [native] Change SQL errors log level.
patch[native] Change SQL errors log level. [applied]